Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating and removing tablet throttler CLI flags and tests #13246

Merged
merged 71 commits into from
Jul 13, 2023
Merged

Deprecating and removing tablet throttler CLI flags and tests #13246

merged 71 commits into from
Jul 13, 2023

Commits on May 22, 2023

  1. Table throttler: --throttler-config-via-topo now defaults to 'true' 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 22, 2023
    Configuration menu
    Copy the full SHA
    920d6ab View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. add deprecation message 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 23, 2023
    Configuration menu
    Copy the full SHA
    7c2ed12 View commit details
    Browse the repository at this point in the history

  2. endtoend tests: remove '--enable-lag-throttler' and use 'UpdateThrott… 

    …lerConfig' everywhere

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 23, 2023
    Configuration menu
    Copy the full SHA
    018b680 View commit details
    Browse the repository at this point in the history

  3. always use vtctldclient 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 23, 2023
    Configuration menu
    Copy the full SHA
    930fb2c View commit details
    Browse the repository at this point in the history

  4. use cluster.VtctldClientProcess 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 23, 2023
    Configuration menu
    Copy the full SHA
    2903164 View commit details
    Browse the repository at this point in the history

  5. disable --throttler-config-via-topo in old throttler tests 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 23, 2023
    Configuration menu
    Copy the full SHA
    681e401 View commit details
    Browse the repository at this point in the history

  6. Remove --throttler-config-via-topo where used, since it now defaults … 

    …'true'

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 23, 2023
    Configuration menu
    Copy the full SHA
    5aea00b View commit details
    Browse the repository at this point in the history

  7. fix vreplication cluster setup, waiting for throttler config to apply 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 23, 2023
    Configuration menu
    Copy the full SHA
    7e5b0fb View commit details
    Browse the repository at this point in the history

  8. changelog 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 23, 2023
    Configuration menu
    Copy the full SHA
    3402fcc View commit details
    Browse the repository at this point in the history

  9. extend throttler threshold 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 23, 2023
    Configuration menu
    Copy the full SHA
    6b02492 View commit details
    Browse the repository at this point in the history

  10. a bit more verbose 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 23, 2023
    Configuration menu
    Copy the full SHA
    e3b8dd1 View commit details
    Browse the repository at this point in the history

  11. fixed CLI test 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 23, 2023
    Configuration menu
    Copy the full SHA
    9bd46a2 View commit details
    Browse the repository at this point in the history

  12. remove old '--enable-lag-throttler' flag, introduce '--heartbeat_on_d… 

    …emand_duration'

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 23, 2023
    Configuration menu
    Copy the full SHA
    c6b9a21 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Merge branch 'main' into throttler-config-default-enable 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach authored May 24, 2023
    Configuration menu
    Copy the full SHA
    4c7a944 View commit details
    Browse the repository at this point in the history

  2. more log info in throttler.Open() 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 24, 2023
    Configuration menu
    Copy the full SHA
    2979d00 View commit details
    Browse the repository at this point in the history

  3. more logging 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 24, 2023
    Configuration menu
    Copy the full SHA
    0890c75 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'throttler-config-default-enable' of github.com:planetsc… 

    …ale/vitess into throttler-config-default-enable

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 24, 2023
    Configuration menu
    Copy the full SHA
    3c893c5 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Revert to --heartbeat_enable 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 30, 2023
    Configuration menu
    Copy the full SHA
    3d3f6b2 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. Protect throttler config change application with initMutex 

    And in e2e test update the throttler config on the keyspace
when it's created. Only wait for the new tablets in a shard
to have the throttler enabled when adding a Shard.

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 31, 2023
    Configuration menu
    Copy the full SHA
    cd2cc1b View commit details
    Browse the repository at this point in the history

  2. More CI testing 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 31, 2023
    Configuration menu
    Copy the full SHA
    7c5b416 View commit details
    Browse the repository at this point in the history

  3. CI testing cont 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 31, 2023
    Configuration menu
    Copy the full SHA
    82b7385 View commit details
    Browse the repository at this point in the history

  4. Yes... 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 31, 2023
    Configuration menu
    Copy the full SHA
    5854273 View commit details
    Browse the repository at this point in the history

  5. Somebody doesn't like force pushes so msg here 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 31, 2023
    Configuration menu
    Copy the full SHA
    5efdc96 View commit details
    Browse the repository at this point in the history

  6. Increase on-demand heartbeat duration from 10s to 1m 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 31, 2023
    Configuration menu
    Copy the full SHA
    5a60e39 View commit details
    Browse the repository at this point in the history

  7. Use only on-demand heartbeats everywhere 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 31, 2023
    Configuration menu
    Copy the full SHA
    34e5dd8 View commit details
    Browse the repository at this point in the history

  8. Use same throttler config everywhere 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 31, 2023
    Configuration menu
    Copy the full SHA
    c420c4a View commit details
    Browse the repository at this point in the history

  9. Update all keyspaces and don't fail test on missing JSON keys 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 31, 2023
    Configuration menu
    Copy the full SHA
    e03df30 View commit details
    Browse the repository at this point in the history

  10. Use constant heartbeats in vrepl e2e tests 

    Until vitessio#13175 is
fixed.

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 31, 2023
    Configuration menu
    Copy the full SHA
    70570a5 View commit details
    Browse the repository at this point in the history

  11. Increase workflow command timeout 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 31, 2023
    Configuration menu
    Copy the full SHA
    dc7b397 View commit details
    Browse the repository at this point in the history

  12. Don't wait for throttler on non-serving primaries 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 31, 2023
    Configuration menu
    Copy the full SHA
    0fc37df View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Merge branch 'main' into throttler-config-default-enable 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    a02478d View commit details
    Browse the repository at this point in the history

  2. vitessio#13175 is fixed, therefore re-instating on-deman heartbeats 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    11ca17a View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into throttler-config-de… 

    …fault-enable

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    065fd16 View commit details
    Browse the repository at this point in the history

  4. Added ToC 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    f4d277d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into throttler-config-default-enable 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach authored Jun 1, 2023
    Configuration menu
    Copy the full SHA
    b7c0419 View commit details
    Browse the repository at this point in the history

  6. Tweak comment and kick CI 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    0de6a72 View commit details
    Browse the repository at this point in the history

  7. Treat isOpen as the ready/running signal. 

    Also align all initMutex usage.

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    261b06a View commit details
    Browse the repository at this point in the history

  8. Re-adjust comment 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    d9bfece View commit details
    Browse the repository at this point in the history

  9. Adjust CheckIsReady() to match OnlineDDL's expectation/usage 

    This was only using IsReady() before, now it's using
IsOpen() and IsReady().

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    d6a9f33 View commit details
    Browse the repository at this point in the history

  10. Get rid of log messages from SrvKeyspaceWatcher when no node/key 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    bbbb351 View commit details
    Browse the repository at this point in the history

  11. More corrections/tweaks 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    48e71a5 View commit details
    Browse the repository at this point in the history

  12. Use more convenient/clear new IsRunning function 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    9aef276 View commit details
    Browse the repository at this point in the history

  13. Revert "Use more convenient/clear new IsRunning function" 

    This reverts commit 9aef276 as this
change was not correct.

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    fc12e4a View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2023

  1. Further fix correct use of IsOpen(), IsRunning(), IsEnabled() 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    ba7aa05 View commit details
    Browse the repository at this point in the history

  2. throttler.throttledApps cannot be nil 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    af0ea43 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Remove --enable_lag_throttler flag 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    04a4908 View commit details
    Browse the repository at this point in the history

  2. Deprecate --throttler_config_via_topo 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    b974eec View commit details
    Browse the repository at this point in the history

  3. remove throttler mitigation code, as the problem was solved in vitess… 

    …io#13195

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    a085d55 View commit details
    Browse the repository at this point in the history

  4. deperecate throttler config flags 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    0f5f4d1 View commit details
    Browse the repository at this point in the history

  5. Removed tabletmanager_throttler and tabletmanager_throttler_custom_co… 

    …nfig tests

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    a7fea0c View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. resolved conflict 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    ba7e3c6 View commit details
    Browse the repository at this point in the history

  2. changelog 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    5893434 View commit details
    Browse the repository at this point in the history

  3. remove EnableThrottler() call 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    fafed16 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. restore default value 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    f29a548 View commit details
    Browse the repository at this point in the history

  2. update threshold 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    f478e6c View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. resolved conflict 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    96f2572 View commit details
    Browse the repository at this point in the history

  2. update flags desc 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    6f3a057 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. resolved conflict 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    37d445a View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. resolved conflict 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    1db2301 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. resolved conflict 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    29847bb View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. using atomic.Bool 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    ce6b94c View commit details
    Browse the repository at this point in the history

  2. Update changelog/18.0/18.0.0/summary.md 

    Co-authored-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach @mattlord
    shlomi-noach and mattlord authored Jul 5, 2023
    Configuration menu
    Copy the full SHA
    3fb71de View commit details
    Browse the repository at this point in the history

  3. Merge branch 'throttler-deprecate-flags' of github.com:planetscale/vi… 

    …tess into throttler-deprecate-flags

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    d460cdc View commit details
    Browse the repository at this point in the history

  4. use MarkDeprecated 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    bc9027e View commit details
    Browse the repository at this point in the history

  5. resolved conflict 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    1fc2595 View commit details
    Browse the repository at this point in the history

  6. do not expect flags in vttablet --help 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    01324bb View commit details
    Browse the repository at this point in the history

  7. remove --throttler-config-via-topo from examples scripts 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    391f20f View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. resolved conflict 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    15b6a28 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Merge branch 'main' into throttler-deprecate-flags 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c3bfcb2 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. resolved conflict 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    8260ce4 View commit details
    Browse the repository at this point in the history

  2. resolved conflict 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    acde739 View commit details
    Browse the repository at this point in the history