VReplication: update column_type for both vstreamer and rowstreamer in a thread safe manner #13285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two bugs:
column_type
vevent attribute was not consistently set in therowstreamer
.column_type
in thevstreamer
was updating the vttablet engine's schema cache. This was incorrect both because it was racy with the schema tracker and because we should not be updating global objects while creating vreplication workflow table plans.The code in #2 is thanks to @brendar and @austenLacy who detected this issue and fixed it in #13045. I have copied it over here so that both the rowstreamer and vstreamer fixes are in one place.
Related Issue(s)
Issue: #12981
Related PR: #13045
Checklist