Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VReplication: Improve MoveTables Create Error Handling #13737

Merged
merged 22 commits into from
Aug 21, 2023
Merged

VReplication: Improve MoveTables Create Error Handling #13737

merged 22 commits into from
Aug 21, 2023

Commits on Aug 7, 2023

  1. MoveTables: don't create routing rules until after streams 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    5a908cf View commit details
    Browse the repository at this point in the history

  2. Add vtctlclient unit test (that fails on main) 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    e478ab2 View commit details
    Browse the repository at this point in the history

  3. Improve comment 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    d200fd7 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Pedantic cleanup 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    637ba76 View commit details
    Browse the repository at this point in the history

  2. Minor changes after self review 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    a1dd8e1 View commit details
    Browse the repository at this point in the history

  3. Stop using t.Fatal in new tests 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    411f2fe View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Merge remote-tracking branch 'origin/main' into movetables_routing 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    d0d0f28 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Add vtctldclient unit test 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    b47fe10 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Automatically clean up on MoveTables Create error 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    d7360b8 View commit details
    Browse the repository at this point in the history

  2. Add missing else in workflow server 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    83f5938 View commit details
    Browse the repository at this point in the history

  3. Restore original logic 

    Meaning that the routing rules are put in place for
partial movetables as well.

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    3c381c4 View commit details
    Browse the repository at this point in the history

  4. Add named return values for workflow case 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    ed1beae View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Merge remote-tracking branch 'origin/main' into movetables_routing 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    fe4a51e View commit details
    Browse the repository at this point in the history

  2. Improve vtctldclient unit test 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    d98416f View commit details
    Browse the repository at this point in the history

  3. Minor tweaks 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    5741fcf View commit details
    Browse the repository at this point in the history

  4. Minor formatting improvements 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    982bc2f View commit details
    Browse the repository at this point in the history

  5. Must stop nitting... 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    f0713ee View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Merge remote-tracking branch 'origin/main' into movetables_routing 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    e3fc307 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2023

  1. Merge remote-tracking branch 'origin/main' into movetables_routing 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    1da742b View commit details
    Browse the repository at this point in the history

  2. Don't fail e2e workflow if schema tracker is slow 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    24d8332 View commit details
    Browse the repository at this point in the history

  3. Turns out that WorkflowDelete isn't the right fit 

    That assumes that all artifacts related to a successfully
created workflow exist. In our case they do not (e.g. the
target tables).

So we add code to rollback any target vschema changes if
we made any.

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    80f8a03 View commit details
    Browse the repository at this point in the history

  4. Address review comment 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    dc2742f View commit details
    Browse the repository at this point in the history