Watch SrvKeyspace instead of polling in VTGate. #1433
Conversation
| newCtx, cancel := context.WithTimeout(context.Background(), *srvTopoTimeout) | ||
| defer cancel() | ||
|
|
||
| result, err := server.topoServer.GetSrvKeyspace(newCtx, cell, keyspace) | ||
| // start watching | ||
| notifications, _, err := server.topoServer.WatchSrvKeyspace(newCtx, cell, keyspace) |
There was a problem hiding this comment.
I am not sure this is right: won't the watch expire when newCtx expires?
There was a problem hiding this comment.
By the way, looking at it now, maybe the WatchSrvKeyspace API is wrong: instead of the stopWatching channel that is returned, WatchSrvKeyspace should just close the notifications channel and return if the context is cancelled. That way the caller can just cancel the context to stop the watch, and that triggers the notification channel to be closed. So the go routine that waist on notifications can just range on the channel.
There was a problem hiding this comment.
Modified so the Watch call uses an empty context without timeout.
I will re-visit the API later.
|
@alainjobart |
| return entry.value, entry.lastError | ||
| } | ||
| entry.lastError = err | ||
| entry.lastErrorCtx = newCtx |
There was a problem hiding this comment.
This should be ctx, the point is for the web page to show who originated the query, otherwise this newCtx is empty.
|
@alainjobart |
|
LGTM |
Watch SrvKeyspace instead of polling in VTGate.
…be handled correctly (#11911) (#11922) (#1433) * bugfix: allow predicates on top of derived tables to be handled without dependencies Signed-off-by: Andres Taylor <andres@planetscale.com> * stop normalizer from changing literals into bindvars Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Andres Taylor <andres@planetscale.com>
@alainjobart @sougou