Revert "[release-16.0] Replace use of WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS with WAIT_FOR_EXECUTED_GTID_SET (#14612)"

[deepthi]

Reverts #14620

because it causes #14738

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[deepthi]

Cluster(12) passed on push but failed on pull_request. Looks like flakiness. We can override and merge after approval.

[rohit-nayak-ps]

Cluster(12) passed on push but failed on pull_request. Looks like flakiness. We can override and merge after approval.

That "success" was because the workflow was skipped lol! Checked because it said finished in 3 seconds.

Added a Do Not Merge for now, it has failed thrice in succession and I am retrying once more. Issue is unlikely related to this PR, but might be worth a look if it fails again.

@GuptaManan100 FYI.

2023-12-09T20:41:24.4276312Z I1209 20:36:27.114068   19013 vtctlclient_process.go:214] Executing vtctlclient with command: vtctlclient --server localhost:16206 PlannedReparentShard -- --keyspace_shard test_keyspace/0 --wait_replicas_timeout 31s --new_primary zone1-361 (attempt 1 of 10)
2023-12-09T20:41:24.4280092Z E1209 20:36:58.216089   19013 vtctlclient_process.go:71] error in PlannedReparentShard output E1209 20:36:58.212578   21854 main.go:96] E1209 20:36:58.212061 planned_reparenter.go:710] some replicas failed to reparent; retry PlannedReparentShard with the same new primary alias ([zone1-0000000361 tablet zone1-0000000362 failed to SetReplicationSource(zone1-0000000361): rpc error: code = DeadlineExceeded desc = context deadline exceeded: rpc error: code = DeadlineExceeded desc = context deadline exceeded]) to retry failed replicas: %!v(MISSING)
2023-12-09T20:41:24.4284306Z PlannedReparentShard Error: rpc error: code = Unknown desc = some replicas failed to reparent; retry PlannedReparentShard with the same new primary alias (zone1-0000000361) to retry failed replicas: tablet zone1-0000000362 failed to SetReplicationSource(zone1-0000000361): rpc error: code = DeadlineExceeded desc = context deadline exceeded: rpc error: code = DeadlineExceeded desc = context deadline exceeded
2023-12-09T20:41:24.4288017Z E1209 20:36:58.214874   21854 main.go:105] remote error: rpc error: code = Unknown desc = some replicas failed to reparent; retry PlannedReparentShard with the same new primary alias (zone1-0000000361) to retry failed replicas: tablet zone1-0000000362 failed to SetReplicationSource(zone1-0000000361): rpc error: code = DeadlineExceeded desc = context deadline exceeded: rpc error: code = DeadlineExceeded desc = context deadline exceeded
2023-12

[GuptaManan100]

Looking at the test failure.