-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable verbose logging for some more RPCs #14770
Enable verbose logging for some more RPCs #14770
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
c6523a4
to
37ee9c8
Compare
unit test is failing.
|
That line in the test just needs to change to Just a note that this PR was motivated by the debugging needed to diagnose #14738. There was no log line for when |
Signed-off-by: Manan Gupta <manan@planetscale.com>
As suggested, I have added a test for |
Description
Went over all the tablet manager RPCs, and specifically for some of the RPCs that are used in reparenting, it is useful to print their responses in the vttablet logs, to debug failures when they occur. Enabling verbose logging, prints a log when the said function finishes execution which can be very helpful information while debugging.
I have been careful in only enabling verbose logging for RPCs, that aren't called on a regular interval, so as to not pollute the logs.
Related Issue(s)
Checklist
Deployment Notes