Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VReplication SwitchWrites: Properly return errors in SwitchWrites #14800

Merged
merged 1 commit into from
Dec 19, 2023
Merged

VReplication SwitchWrites: Properly return errors in SwitchWrites #14800

merged 1 commit into from
Dec 19, 2023

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Dec 18, 2023 •
edited
Loading

Description

During a refactor there was a regression where some errors were just being logged and not returned. This PR correctly returns them to the caller.

Original commit where this was introduced: 89295b5#diff-a071a972abd45af831ed93cc6447a87b83cee112f1c7d3bb0bdd592979d80c91

Related Issue(s)

#13656

Fixes: #14801

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@rohit-nayak-ps
Properly return errors in SwitchWrites
ac11163 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 18, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 18, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Dec 18, 2023
@rohit-nayak-ps rohit-nayak-ps added Type: Bug Component: VReplication and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Dec 18, 2023
@rohit-nayak-ps rohit-nayak-ps removed the NeedsIssue A linked issue is missing for this Pull Request label Dec 18, 2023
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review December 18, 2023 17:04
@rohit-nayak-ps rohit-nayak-ps requested a review from a team December 18, 2023 17:04
@rohit-nayak-ps rohit-nayak-ps merged commit 91bb0b9 into vitessio:main Dec 19, 2023
118 of 120 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the rohit/fix-incorrect-traffic-switcher-error-handling branch December 19, 2023 11:05
rohit-nayak-ps added a commit to planetscale/vitess that referenced this pull request Dec 19, 2023
@rohit-nayak-ps
VReplication SwitchWrites: Properly return errors in SwitchWrites (vi…
f21e23e 
…tessio#14800)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps mentioned this pull request Dec 19, 2023
Merged
5 tasks
harshit-gangal pushed a commit that referenced this pull request Dec 20, 2023
@rohit-nayak-ps
[release-18.0] Backport: VReplication SwitchWrites: Properly return e…
6e7937c 
…rrors in SwitchWrites #14800 (#14824)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Jan 24, 2024
@rohit-nayak-ps @ejortegau
VReplication SwitchWrites: Properly return errors in SwitchWrites (vi…
d93c52d 
…tessio#14800)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Eduardo J. Ortega U. <5791035+ejortegau@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbussink dbussink dbussink approved these changes

@mattlord mattlord mattlord approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Component: VReplication NeedsBackportReason If backport labels have been applied to a PR, a justification is required Type: Bug
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.

Some errors in SwitchWrites are not handled properly
3 participants
@rohit-nayak-ps @dbussink @mattlord