Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelogs: squash 19.0.2/19.0.3 into just 19.0.3 and remove 19.0.2 #15665

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

systay
Copy link
Collaborator

@systay systay commented Apr 4, 2024

Description

Since we don't want people to use 19.0.2, we edit the changelogs to make it seem like all changes in 19.0.2 and 19.0.3 happened in 19.03

Related Issue(s)

#15656
#15572

Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay requested a review from deepthi as a code owner April 4, 2024 16:33
Copy link
Contributor

vitess-bot bot commented Apr 4, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 4, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Apr 4, 2024
@systay systay added Type: Internal Cleanup Component: General Changes throughout the code base Type: Release Backport to: release-19.0 Needs to be back ported to release-19.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required Type: Internal Cleanup Type: Release labels Apr 4, 2024
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.13%. Comparing base (696fe0e) to head (5428e49).
Report is 195 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15665      +/-   ##
==========================================
+ Coverage   67.41%   68.13%   +0.71%     
==========================================
  Files        1560     1556       -4     
  Lines      192752   195028    +2276     
==========================================
+ Hits       129952   132885    +2933     
+ Misses      62800    62143     -657     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui frouioui merged commit 795c678 into vitessio:main Apr 4, 2024
103 checks passed
@frouioui frouioui deleted the rip-19-2 branch April 4, 2024 17:27
vitess-bot pushed a commit that referenced this pull request Apr 4, 2024
…15665)

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit that referenced this pull request Apr 4, 2024
…remove 19.0.2 (#15665) (#15668)

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to: release-19.0 Needs to be back ported to release-19.0 Component: General Changes throughout the code base Type: Internal Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants