-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysqlctld: Remove unneeded resets in init_db.sql #15832
Merged
dbussink
merged 1 commit into
vitessio:main
from
planetscale:dbussink/remove-unneeded-resets
May 2, 2024
Merged
mysqlctld: Remove unneeded resets in init_db.sql #15832
dbussink
merged 1 commit into
vitessio:main
from
planetscale:dbussink/remove-unneeded-resets
May 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbussink
requested review from
GuptaManan100,
frouioui,
mattlord,
shlomi-noach and
deepthi
as code owners
May 2, 2024 14:26
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
May 2, 2024
dbussink
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
May 2, 2024
This removes the resets for the startup script that we use. These were long ago added for a MariaDB 10.3 workaround which is not supported as a managed tablet anyway anymore. It also would only needed for an existing node to join a cluster that is otherwise manually emptied. If that's the case, the reset should also be done manually anyway too. Removing this also ensures we have no logic here that would start failing in the future on MySQL 8.4.0 which removed these statements. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
dbussink
force-pushed
the
dbussink/remove-unneeded-resets
branch
from
May 2, 2024 14:30
1f0137d
to
0abb087
Compare
mdlayher
approved these changes
May 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15832 +/- ##
==========================================
- Coverage 68.43% 68.41% -0.03%
==========================================
Files 1559 1559
Lines 196496 196496
==========================================
- Hits 134474 134432 -42
- Misses 62022 62064 +42 ☔ View full report in Codecov by Sentry. |
mattlord
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the resets for the startup script that we use. These were long ago added for a MariaDB 10.3 workaround which is not supported as a managed tablet anyway anymore.
It also would only needed for an existing node to join a cluster that is otherwise manually emptied. If that's the case, the reset should also be done manually anyway too.
Removing this also ensures we have no logic here that would start failing in the future on MySQL 8.4.0 which removed these statements.
Related Issue(s)
Part of #9515
Checklist