Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VTCombo: Ensure VSchema exists when creating keyspace #16094

Merged
merged 2 commits into from
Jul 11, 2024
Merged

VTCombo: Ensure VSchema exists when creating keyspace #16094

merged 2 commits into from
Jul 11, 2024

Conversation

brendar
Copy link
Contributor

@brendar brendar commented Jun 10, 2024 •
edited by mattlord
Loading

Description

Ensures that a VSchema exists whenever a keyspace is created by VTCombo

Related Issue(s)

Fixes #16088

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

None

@brendar brendar requested a review from deepthi as a code owner June 10, 2024 17:36
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jun 10, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 10, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jun 10, 2024
@brendar brendar mentioned this pull request Jul 3, 2024
Closed
@mattlord mattlord added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VTCombo and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 8, 2024
mattlord
mattlord approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @brendar ! ❤️

go/test/endtoend/vtcombo/vttest_sample_test.go Outdated
log.Infof("Running vtctldclient with command: %v", tmpCmd.Args)

output, err := tmpCmd.CombinedOutput()
require.Nil(t, err, fmt.Sprintf("Output:\n%v", string(output)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but require.NoError is a bit more explicit.

@codecov Codecov
Copy link

codecov bot commented Jul 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.70%. Comparing base (ff3425f) to head (1fadc8c).
Report is 1 commits behind head on main.

Files Patch % Lines
go/vt/vtcombo/tablet_map.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16094      +/-   ##
==========================================
- Coverage   68.71%   68.70%   -0.02%     
==========================================
  Files        1547     1547              
  Lines      198291   198293       +2     
==========================================
- Hits       136256   136231      -25     
- Misses      62035    62062      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattlord
Copy link
Contributor

mattlord commented Jul 8, 2024 •
edited
Loading

@brendar can you please merge origin/main? The failing test should then pass.

@brendar
VTCombo: Ensure VSchema exists when creating keyspace
570a358 
Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com>
@brendar
Prefer require.NoError
1fadc8c 
Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com>
@brendar brendar force-pushed the ensure-vschema-in-vtcombo branch from 58a66b8 to 1fadc8c Compare July 9, 2024 14:05
@brendar
Copy link
Contributor Author

brendar commented Jul 9, 2024

@mattlord Thanks for the review. Rebased and tests are green.

@deepthi deepthi merged commit 0f242e9 into vitessio:main Jul 11, 2024
126 checks passed
brendar added a commit to Shopify/vitess that referenced this pull request Jul 16, 2024
@brendar
Backport: VTCombo: Ensure VSchema exists when creating keyspace (vite…
dab2d1a 
…ssio#16094)

Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com>
brendar added a commit to Shopify/vitess that referenced this pull request Jul 16, 2024
@brendar
Backport: VTCombo: Ensure VSchema exists when creating keyspace (vite…
e1988c0 
…ssio#16094)

Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com>
brendar added a commit to Shopify/vitess that referenced this pull request Jul 16, 2024
@brendar
VTCombo: Ensure VSchema exists when creating keyspace (vitessio#16094)
17752f5 
Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com>
brendar added a commit to Shopify/vitess that referenced this pull request Jul 16, 2024
@brendar
Backport: VTCombo: Ensure VSchema exists when creating keyspace (vite…
1ab427d 
…ssio#16094)

Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com>
brendar added a commit to Shopify/vitess that referenced this pull request Jul 16, 2024
@brendar
Merge pull request #171 from Shopify/v18.0.5-shopify-2-candidate
a1eceeb 
Backport: VTCombo: Ensure VSchema exists when creating keyspace (vitessio#16094)
brendar added a commit to Shopify/vitess that referenced this pull request Jul 16, 2024
@brendar
Backport: VTCombo: Ensure VSchema exists when creating keyspace (vite…
b798923 
…ssio#16094)

Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com>
brendar added a commit to Shopify/vitess that referenced this pull request Jul 18, 2024
@brendar
Merge pull request #175 from Shopify/v19.0.4-shopify-2-candidate-back…
4b24c58 
…port-vtcombo-vschema

Backport: VTCombo: Ensure VSchema exists when creating keyspace (vitessio#16094)
shanth96 pushed a commit to Shopify/vitess that referenced this pull request Jul 26, 2024
@brendar @shanth96
Merge pull request #175 from Shopify/v19.0.4-shopify-2-candidate-back…
1b71895 
…port-vtcombo-vschema

Backport: VTCombo: Ensure VSchema exists when creating keyspace (vitessio#16094)
(cherry picked from commit 4b24c58)
venkatraju pushed a commit to slackhq/vitess that referenced this pull request Aug 29, 2024
@brendar @venkatraju
VTCombo: Ensure VSchema exists when creating keyspace (vitessio#16094)
db894c6 
Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@mattlord mattlord mattlord approved these changes

Assignees
No one assigned
Labels
Component: VTCombo Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v21.0.0
Development

Successfully merging this pull request may close these issues.

Bug Report: VTCombo does not create VSchema in topo
3 participants
@brendar @mattlord @deepthi