-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-20.0-rc] feat: add a LIMIT 1 on EXISTS subqueries to limit network overhead (#16153) #16192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…16153) Signed-off-by: Andres Taylor <andres@planetscale.com>
vitess-bot
bot
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Type: Regression
labels
Jun 14, 2024
vitess-bot
bot
requested review from
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
June 14, 2024 17:37
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
systay
approved these changes
Jun 14, 2024
frouioui
approved these changes
Jun 14, 2024
frouioui
added
Release Blocker: release-20.0
This item blocks the release on branch release-20.0
and removed
Release Blocker: release-20.0
This item blocks the release on branch release-20.0
labels
Jun 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-20.0-rc #16192 +/- ##
===================================================
+ Coverage 68.47% 68.49% +0.01%
===================================================
Files 1541 1541
Lines 197614 197709 +95
===================================================
+ Hits 135314 135411 +97
+ Misses 62300 62298 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport
This is a backport
Component: Query Serving
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Type: Regression
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #16153