Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throttler code: some refactoring and cleanup #16368

Merged
merged 21 commits into from
Jul 17, 2024
Merged

Throttler code: some refactoring and cleanup #16368

merged 21 commits into from
Jul 17, 2024

Commits on Jul 11, 2024

  1. rename variable mysqlMetricThresholds to metricThresholds 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    5fb9a6e View commit details
    Browse the repository at this point in the history

  2. rename function mysqlMetricThresholdsSnapshot to metricThresholdsSnap… 

    …shot

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c6d7047 View commit details
    Browse the repository at this point in the history

  3. rename *Interval variables away from 'mysql' 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    9eb59b3 View commit details
    Browse the repository at this point in the history

  4. rename *Interval variables away from 'mysql' 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    9f2716a View commit details
    Browse the repository at this point in the history

  5. rename aggregateMySQLProbes -> aggregateMetricResults. Cleanup tests 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    685441e View commit details
    Browse the repository at this point in the history

  6. rename MySQLThrottleMetrics -> ThrottleMetrics. Rename mysqlThrottleM… 

    …etricChan -> throttleMetricChan

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    dd11de1 View commit details
    Browse the repository at this point in the history

  7. renamed files 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c9ac150 View commit details
    Browse the repository at this point in the history

  8. rename file 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    dd3868f View commit details
    Browse the repository at this point in the history

  9. eliminatye throttle/mysql package; move everything under throttle/base 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    2886bf3 View commit details
    Browse the repository at this point in the history

  10. Remove unused type 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    f6e8a55 View commit details
    Browse the repository at this point in the history

  11. remove ctx argument 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    1ea1b51 View commit details
    Browse the repository at this point in the history

  12. rename aggregateMetricResults -> aggregateTabletMetricResults 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    1bddcc0 View commit details
    Browse the repository at this point in the history

  13. shuffle code around, moving aggregateTabletMetricResults into 'base' … 

    …package

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    ec62bbe View commit details
    Browse the repository at this point in the history

  14. remove ctx where unused 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c82ea9a View commit details
    Browse the repository at this point in the history

  15. terminology: remove 'MySQL' where irrelevant. Add where relevant 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    3423780 View commit details
    Browse the repository at this point in the history

  16. terminology: remove 'MySQL' where irrelevant 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    1f584a1 View commit details
    Browse the repository at this point in the history

  17. renamed getMySQLStoreMetric -> getScopedMetric 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    85994ed View commit details
    Browse the repository at this point in the history

  18. comment wording 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    2492d6d View commit details
    Browse the repository at this point in the history

  19. adding missing files 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    8c20483 View commit details
    Browse the repository at this point in the history

  20. Merge branch 'main' into throttler-cleanup-types-and-names 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d913132 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. update copyright year 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    a8eeea7 View commit details
    Browse the repository at this point in the history