Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throttler: return app name in check result, synthesize "why throttled" explanation from result #16416

Merged
merged 41 commits into from
Jul 28, 2024
Merged

Throttler: return app name in check result, synthesize "why throttled" explanation from result #16416

merged 41 commits into from
Jul 28, 2024

Commits on Jul 11, 2024

  1. rename variable mysqlMetricThresholds to metricThresholds 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    5fb9a6e View commit details
    Browse the repository at this point in the history

  2. rename function mysqlMetricThresholdsSnapshot to metricThresholdsSnap… 

    …shot

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c6d7047 View commit details
    Browse the repository at this point in the history

  3. rename *Interval variables away from 'mysql' 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    9eb59b3 View commit details
    Browse the repository at this point in the history

  4. rename *Interval variables away from 'mysql' 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    9f2716a View commit details
    Browse the repository at this point in the history

  5. rename aggregateMySQLProbes -> aggregateMetricResults. Cleanup tests 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    685441e View commit details
    Browse the repository at this point in the history

  6. rename MySQLThrottleMetrics -> ThrottleMetrics. Rename mysqlThrottleM… 

    …etricChan -> throttleMetricChan

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    dd11de1 View commit details
    Browse the repository at this point in the history

  7. renamed files 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c9ac150 View commit details
    Browse the repository at this point in the history

  8. rename file 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    dd3868f View commit details
    Browse the repository at this point in the history

  9. eliminatye throttle/mysql package; move everything under throttle/base 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    2886bf3 View commit details
    Browse the repository at this point in the history

  10. Remove unused type 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    f6e8a55 View commit details
    Browse the repository at this point in the history

  11. remove ctx argument 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    1ea1b51 View commit details
    Browse the repository at this point in the history

  12. rename aggregateMetricResults -> aggregateTabletMetricResults 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    1bddcc0 View commit details
    Browse the repository at this point in the history

  13. shuffle code around, moving aggregateTabletMetricResults into 'base' … 

    …package

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    ec62bbe View commit details
    Browse the repository at this point in the history

  14. remove ctx where unused 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c82ea9a View commit details
    Browse the repository at this point in the history

  15. terminology: remove 'MySQL' where irrelevant. Add where relevant 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    3423780 View commit details
    Browse the repository at this point in the history

  16. terminology: remove 'MySQL' where irrelevant 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    1f584a1 View commit details
    Browse the repository at this point in the history

  17. renamed getMySQLStoreMetric -> getScopedMetric 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    85994ed View commit details
    Browse the repository at this point in the history

  18. comment wording 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    2492d6d View commit details
    Browse the repository at this point in the history

  19. tests: explicitly disabling throttler so as to ensure it does not re-… 

    …enable

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d7c63c8 View commit details
    Browse the repository at this point in the history

  20. CheckThrottlerResponse: include the matched app name 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    114405f View commit details
    Browse the repository at this point in the history

  21. CheckThrottler: return matched app name 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    692f7d5 View commit details
    Browse the repository at this point in the history

  22. adding missing files 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    090f96d View commit details
    Browse the repository at this point in the history

  23. adding missing files 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    8c20483 View commit details
    Browse the repository at this point in the history

  24. Merge branch 'main' into throttler-cleanup-types-and-names 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d913132 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. update copyright year 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    a8eeea7 View commit details
    Browse the repository at this point in the history

  2. resolved conflict 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f6fda40 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Merge branch 'main' into throttler-response-app 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    ca9b878 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Merge branch 'main' into throttler-response-app 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ff04023 View commit details
    Browse the repository at this point in the history

  2. remove unused httpClient 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    eb0635d View commit details
    Browse the repository at this point in the history

  3. adding Summary in CheckThrottlerResponse 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    032c87a View commit details
    Browse the repository at this point in the history

  4. evaluate and populate metric result Summary 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    3527745 View commit details
    Browse the repository at this point in the history

  5. apply matchedApp on indirect throttling. Add testing 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    32d1f3c View commit details
    Browse the repository at this point in the history

  6. proto: add ThrottledReason in VStreamRowsResponse and in VEvent 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    0f48902 View commit details
    Browse the repository at this point in the history

  7. ThrottlerClient returns CheckResult. Used in vreplication to extract … 

    …the Summary(), populate ThrottledReason added in proto, then in turn populate new _vt.vreplication.reason_throttled

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    af99924 View commit details
    Browse the repository at this point in the history

  8. copy _vt.vreplication.reason_throttled to _vt.schema_migrations.reaso… 

    …n_throttled

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    b31a552 View commit details
    Browse the repository at this point in the history

  9. test 'reason_throttled' in endtoend 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    313675c View commit details
    Browse the repository at this point in the history

  10. fix expected message 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    5a3aea7 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Merge branch 'main' into throttler-response-app 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f66da96 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. string format 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    2cd72f1 View commit details
    Browse the repository at this point in the history

  2. remove extraneous comment indicator. 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    d6e3f45 View commit details
    Browse the repository at this point in the history

  3. formalize expected check result summary based on app name 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    0eef755 View commit details
    Browse the repository at this point in the history