Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v20 backport: Throttler/vreplication: fix app name used by VPlayer (#16578) #16579

Merged

Conversation

shlomi-noach
Copy link
Contributor

Manual backport of #16578 to 20.0

Description

VPlayer was incorrectly identifying itself to the throttler as vcopier. As result, running ApplyThrottlerConfig --throttle-app=vplayer made no effect on VPlayer. This PR fixes the problem.

Related Issue(s)

Context: #16575 (this PR does not fix this issue, just related)

Backports

This is a bug. Backporting to 20, 19, 18 where this issue is relevant.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach requested a review from a team August 11, 2024 10:56
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.68%. Comparing base (3e8ce7e) to head (815b5fe).

Additional details and impacted files
@@              Coverage Diff              @@
##           release-20.0   #16579   +/-   ##
=============================================
  Coverage         68.67%   68.68%           
=============================================
  Files              1541     1541           
  Lines            197870   197870           
=============================================
+ Hits             135888   135900   +12     
+ Misses            61982    61970   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shlomi-noach shlomi-noach merged commit 3f926b6 into vitessio:release-20.0 Aug 12, 2024
101 checks passed
@shlomi-noach shlomi-noach deleted the backport-16578-to-20.0 branch August 12, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants