Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-18.0] VReplication workflows: retry "wrong tablet type" errors (#16645) #16651

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Aug 26, 2024

Description

This is a backport of #16645

@vitess-bot vitess-bot bot added Backport This is a backport Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Component: VReplication Merge Conflict Skip CI Skip CI actions from running Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Aug 26, 2024
Copy link
Contributor Author

vitess-bot bot commented Aug 26, 2024

Hello @rohit-nayak-ps, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 16651 -R vitessio/vitess
git reset --hard origin/release-18.0
git cherry-pick -m 1 d1d6bd88641ddc06f75a6d94cbd2aed37d62ee81

Copy link
Contributor Author

vitess-bot bot commented Aug 26, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v18.0.7 milestone Aug 26, 2024
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps removed Skip CI Skip CI actions from running Merge Conflict labels Aug 27, 2024
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review August 27, 2024 08:48
@rohit-nayak-ps rohit-nayak-ps merged commit e8c5e5b into release-18.0 Aug 27, 2024
205 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the backport-16645-to-release-18.0 branch August 27, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport This is a backport Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants