Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: authoritative query timeout for vttablet from vtgate #16735

Merged
merged 15 commits into from
Sep 11, 2024
Merged

feat: authoritative query timeout for vttablet from vtgate #16735

merged 15 commits into from
Sep 11, 2024

Commits on Sep 9, 2024

  1. feat: add query timeout to execute options to proto 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    f598f70 View commit details
    Browse the repository at this point in the history

  2. feat: use authoritative timeout from execute options if provided 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    5a693ff View commit details
    Browse the repository at this point in the history

  3. feat: set query timeout on execute options and refactor query hints 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    4451119 View commit details
    Browse the repository at this point in the history

  4. take query timeout set at session into account 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    7e01664 View commit details
    Browse the repository at this point in the history

  5. fix: timeout in milliseconds 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    0ef24ab View commit details
    Browse the repository at this point in the history

  6. feat: set query timeout on query execution at vtgate 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    bb03bc9 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. added test to tablet changes 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    061c1f0 View commit details
    Browse the repository at this point in the history

  2. fix: context cancel call 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    5e1ec56 View commit details
    Browse the repository at this point in the history

  3. removed all leaf level context timeout setting for non-streaming 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    af6de49 View commit details
    Browse the repository at this point in the history

  4. test: added e2e test 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    e061353 View commit details
    Browse the repository at this point in the history

  5. test: added unit test 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d8ba52b View commit details
    Browse the repository at this point in the history

  6. addressed review comment 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    71aa779 View commit details
    Browse the repository at this point in the history

  7. move cancel func to other variable declaration 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    118e246 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/main' into query-timeout 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    0637b82 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. added release notes 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a857a5e View commit details
    Browse the repository at this point in the history