Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Images Build CI action: add updated version from release-20.0 back in prep for v21 release #16799

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

rohit-nayak-ps
Copy link
Contributor

Description

The docker images build action was deleted temporarily in #16759. However we do need this action to build for release tags. Given that we have v21.0 coming up, this PR adds the workflow back. However it only runs it for the tags

  push:
    branches:
      - main
    tags:
      - 'v[2-9][0-9]*.*' # run only on tags greater or equal to v20.0.0 where this new way of building docker image was changed
  workflow_dispatch:

Note that this has also added the workflow_dispatch trigger, so that we can manually run this from the GitHub UI easily if required. We had an issue recently with Docker Hub throttling and it was non-trivial to find the failed action to rerun.

This also changes the github instance it runs on to ubuntu-latest in line with the recently announced instance changes in GitHub Actions.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

…ed. Changed runs-on to ubuntu-latest

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Copy link
Contributor

vitess-bot bot commented Sep 17, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 17, 2024
@rohit-nayak-ps rohit-nayak-ps added Component: Build/CI Type: CI/Build and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Sep 17, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Sep 17, 2024
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review September 24, 2024 19:17
@frouioui frouioui merged commit 5e9c69c into vitessio:main Sep 24, 2024
106 of 107 checks passed
@frouioui frouioui deleted the rohit/docker-build-action branch September 24, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants