Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add savepoint support to atomic distributed transaction #16863

Merged
merged 8 commits into from
Oct 10, 2024

Conversation

harshit-gangal
Copy link
Member

Description

This PR adds support for savepoints usage in atomic distributed transaction commit by storing the savepoints in the transaction query log and then reapplying them on a recovery.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Sep 30, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 30, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Sep 30, 2024
@harshit-gangal harshit-gangal added Type: Feature Request Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 76.29630% with 32 lines in your changes missing coverage. Please review.

Project coverage is 69.42%. Comparing base (056afc9) to head (bc836c4).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vttablet/tabletserver/tabletserver.go 64.28% 20 Missing ⚠️
go/vt/vttablet/tabletserver/planbuilder/plan.go 66.66% 5 Missing ⚠️
go/vt/vttablet/tabletserver/query_executor.go 85.71% 4 Missing ⚠️
go/vt/vttablet/tabletserver/tx/api.go 85.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16863      +/-   ##
==========================================
- Coverage   69.45%   69.42%   -0.04%     
==========================================
  Files        1570     1570              
  Lines      203631   203921     +290     
==========================================
+ Hits       141441   141563     +122     
- Misses      62190    62358     +168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…mit on it. added multiple e2e test cases

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…rver

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@vitess-bot vitess-bot modified the milestones: v21.0.0, v22.0.0 Oct 8, 2024
@@ -60,13 +59,13 @@ type (

Stats *servenv.TimingsWrapper
}
Query struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add some comments? the type is not self evident, imho

Copy link
Collaborator

@systay systay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from some nitpicks, LGTM

harshit-gangal and others added 2 commits October 8, 2024 17:14
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal merged commit a7b903b into vitessio:main Oct 10, 2024
98 checks passed
@harshit-gangal harshit-gangal deleted the savepoint-2pc branch October 10, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants