Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-metrics throttler: post v21 deprecations and changes #16915

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Multi-metrics throttler: post v21 deprecations and changes #16915

wants to merge 8 commits into from
+288 −925

Commits on Oct 8, 2024

  1. remove MultiMetricsEnabled, now assumed to be true in v22 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    c031e00 View commit details
    Browse the repository at this point in the history

  2. remove use of MultiMetricsEnabled (now assumed to be 'true' at all ti… 

    …mes)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    7c72938 View commit details
    Browse the repository at this point in the history

  3. adapt and fix tests 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    c47d5ac View commit details
    Browse the repository at this point in the history

  4. load average self metric is empty (zero) on non-linux, rather than error 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    0bf2cef View commit details
    Browse the repository at this point in the history

  5. Remove expired/unthrottled rules from topo rather than set them to 0 … 

    …expiration duration

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e118807 View commit details
    Browse the repository at this point in the history

  6. Remove --check-as-check-self, --check-as-check-shard flags and all as… 

    …sociated implementation

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    d5c4672 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Remove StatusCode from throttler responses and throttler recent apps 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d02f70e View commit details
    Browse the repository at this point in the history

  2. Removing HTTP StatusCode now that we have a formal ResponseCode 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ef5ccc5 View commit details
    Browse the repository at this point in the history