-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flakiness in TestListenerShutdown
#17024
Fix flakiness in TestListenerShutdown
#17024
Conversation
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17024 +/- ##
==========================================
- Coverage 67.17% 67.16% -0.01%
==========================================
Files 1571 1571
Lines 252249 252249
==========================================
- Hits 169459 169434 -25
- Misses 82790 82815 +25 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
…own-flakiness Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Description
This is a follow up of #16940 where the test was modified to alleviate flakiness.
This PR aims at removing (or at least reducing) the flakiness observed on
TestListenerShutdown
. This test almost never fails on this repository's CI, but I have observed several failures in other repositories where the CI is less beefy. The original error was:I ran this fix ten times in another repository where the issue was first observed, and it passed successfully the ten times.