-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix SchemaCacheConfig.DefaultExpiration #17609
fix SchemaCacheConfig.DefaultExpiration #17609
Conversation
Signed-off-by: Matthias Crauwels <matthias.crauwels@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility N/A
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Matthias! :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17609 +/- ##
==========================================
- Coverage 67.68% 67.66% -0.03%
==========================================
Files 1586 1586
Lines 255170 255403 +233
==========================================
+ Hits 172722 172828 +106
- Misses 82448 82575 +127 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Matthias Crauwels <matthias.crauwels@planetscale.com>
Signed-off-by: Matthias Crauwels <matthias.crauwels@planetscale.com>
Description
fixing the cache duration for the SchemaCacheConfig items
Backport reason: bug affecting users requiring at least v20.
Related Issue(s)
fixes #17608
Checklist
Deployment Notes