Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SchemaCacheConfig.DefaultExpiration #17609

Conversation

mcrauwel
Copy link
Contributor

@mcrauwel mcrauwel commented Jan 22, 2025

Description

fixing the cache duration for the SchemaCacheConfig items

Backport reason: bug affecting users requiring at least v20.

Related Issue(s)

fixes #17608

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Matthias Crauwels <matthias.crauwels@planetscale.com>
Copy link
Contributor

vitess-bot bot commented Jan 22, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change. None needed
  • New features should be documented. Not new feature
  • There should be some code comments as to why things are implemented the way they are. N/A
  • There should be a comment at the top of each new or modified test to explain what the test does. N/A

New flags

  • Is this flag really necessary? N/A
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text. N/A

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required. NA
  • If the workflow needs to be marked as required, the maintainer team must be notified. N/A

Backward compatibility N/A

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 22, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Jan 22, 2025
Copy link
Contributor

@notfelineit notfelineit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matthias! :)

@notfelineit notfelineit added Type: Bug Component: VTAdmin VTadmin interface go Backport to: release-20.0 Needs to be backport to release-20.0 Backport to: release-21.0 Needs to be backport to release-21.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.66%. Comparing base (d1aa2f4) to head (229db8f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17609      +/-   ##
==========================================
- Coverage   67.68%   67.66%   -0.03%     
==========================================
  Files        1586     1586              
  Lines      255170   255403     +233     
==========================================
+ Hits       172722   172828     +106     
- Misses      82448    82575     +127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohit-nayak-ps rohit-nayak-ps merged commit 99856a2 into vitessio:main Jan 22, 2025
105 of 118 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the planetscale/mcrauwel/schema-cache-expiration branch January 22, 2025 17:00
vitess-bot pushed a commit that referenced this pull request Jan 22, 2025
Signed-off-by: Matthias Crauwels <matthias.crauwels@planetscale.com>
vitess-bot pushed a commit that referenced this pull request Jan 22, 2025
Signed-off-by: Matthias Crauwels <matthias.crauwels@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to: release-20.0 Needs to be backport to release-20.0 Backport to: release-21.0 Needs to be backport to release-21.0 Component: VTAdmin VTadmin interface go Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: vtadmin schema cache default expiration not properly used
3 participants