Better comments for pip update. #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,13 +22,15 @@ fi | |||
| # Python requires a very recent version of virtualenv. | |||
| if [ -n "$grpc_dist" ]; then | |||
| # Create a virtualenv, which also creates a virualenv-boxed pip. | |||
| # Update both pip and virtualenv. | |||
There was a problem hiding this comment.
Please change the comment such that it explains why we're doing this and include any relevant pointers e.g. URL to a bug.
I think the reason is that the "setuptools" (which is installed by the protobuf package) needs a more recent pip binary. It looks like this is the relevant bug: pypa/setuptools#945
There was a problem hiding this comment.
Done, thanks for the link.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.