mysqlconn: switching to new library for constants. #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alainjobart
commented
Feb 1, 2017
•
alainjobart
commented
- fixing error code for mysqlconn.Connect. Turns out TCP socket error code is different from Unix socket for mysql client.
- move SSL params to conn_params.
- refactoring all error codes into the new library.
- minor change in QueryServiceStats to remove a lint warning.
Turns out TCP socket error code is different from Unix socket.
That removes a bunch of dependencies, so have to do an anonymous import in dbconfigs.
That way the context can be the first parameter, and remove the warning.
alainjobart
changed the title
|
@sougou this is probably the last of these clean-up reviews. Now the old go/mysql is only imported in a couple places so the implementation can be used by default. |
|
LGTM |
frouioui
pushed a commit
to planetscale/vitess
that referenced
this pull request
Nov 21, 2023
…n Workflows: make sequence tables follow routing rules (vitessio#2528) * backport of 2526 * Adjust new workflows for vitess-private Signed-off-by: Matt Lord <mattalord@gmail.com> * Use basic vs simple everywhere for new workflow Signed-off-by: Matt Lord <mattalord@gmail.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com>
frouioui
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.