Ignore any IDs generated by the DB #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is causing us issues as we need to use MySQL directly and from Vitess for a transition period. This could possibly be a command line flag but I think it's fine to just ignore the MySQL generated ID. That's after all what MySQL does, if you provide an ID when inserting it just ignored the autoinc column. |
sougou
reviewed
Feb 21, 2017
go/vt/vtgate/engine/route.go
Outdated
| @@ -447,9 +447,6 @@ func (route *Route) execInsertUnsharded(vcursor VCursor, queryConstruct *queryin | |||
| return nil, fmt.Errorf("execInsertUnsharded: %v", err) | |||
| } | |||
| if insertid != 0 { | |||
go/vt/vtgate/router_dml_test.go
Outdated
| @@ -722,6 +722,10 @@ func TestInsertFail(t *testing.T) { | |||
| if err == nil || !strings.HasPrefix(err.Error(), want) { | |||
| t.Errorf("routerExec: %v, want prefix %v", err, want) | |||
| } | |||
| } | |||
|
|
|||
| func TestIgnoresAutoincGeneratedByMySQL(t *testing.T) { | |||
There was a problem hiding this comment.
You can also delete this test. It's essentially obsolete now.
tirsen
force-pushed
the
ignore-mysql-autoinc
branch
from
374e5cb
to
1d368fd
Compare
tirsen
force-pushed
the
ignore-mysql-autoinc
branch
from
1d368fd
to
7091d20
Compare
|
Alright, comments addressed please have another look. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.