vtgate/buffer: Fix bug that keyspaces were not logged at startup. #2578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happened only when shards were included as well.
alainjobart
approved these changes
Feb 22, 2017
frouioui
pushed a commit
to planetscale/vitess
that referenced
this pull request
Nov 21, 2023
…#13434) (vitessio#2573) (vitessio#2578) * tcp keep alive and period settings * added e2e test for tcp keep alive * added unit test and removed e2e test due to cgo dependency * addressed review comments * introduce a marker on conn to know if keepalive is on, used for testing --------- Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happened only when shards were included as well.