Added documentation for the replication-lag-based-throttler #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alainjobart
reviewed
Feb 23, 2017
| # Caveats and Known Issues | ||
| * The throttler keeps trying to explore the maximum rate possible while keeping | ||
| the replication lag under the desired limit; as such the desired replication | ||
| lag limit may occaisionally be slightly violated. |
| A comma separated list of datacenter cells. The throttler will only monitor | ||
| the non-RDONLY replicas found in these cells for replication lag. | ||
|
|
||
| # Caveats and Known Issues |
There was a problem hiding this comment.
you need a new line after the title?
| protocol buffer that contains configuration options for the throttler. | ||
| The most important fields in that message are *target_replication_lag_sec* and | ||
| *max_replication_lag_sec* that specify the desired limits on the replication lag. See the comments in the protocol definition file for more details. | ||
| If this is not specified a default configuration will be used. |
There was a problem hiding this comment.
is there a sample config in the tests? if so, link to it would be good.
erzel
force-pushed
the
adding_replication_lag_based_throttler_doc
branch
from
52c5cef
to
2dfccb4
Compare
|
Thanks for reviewing. PTAL. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@michael-berlin @alainjobart