Add kubernetes api server config #2603
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
@googlebot I signed it! |
examples/kubernetes/env.sh
Outdated
| # Kuberentes api address for $KUBECTL | ||
| # The default value is 127.0.0.1:8080 | ||
| # When the Kuberentes api server is not local, We can easily access the api by edit KUBERENETAPI's value | ||
| KUBERENETAPI=${KUBERENETAPI:-'127.0.0.1:8080'} |
There was a problem hiding this comment.
Can you fix the comments to say Kubernetes instead of Kuberentes? Also can you name this var KUBERNETES_API_SERVER to be clearer?
One thing that might help make life simpler in case we need to add any other flags in the future is to create a var in env.sh called KUBECTL_OPTIONS, which would just be '--namespace=$VITESS_NAME --server=$KUBERNETES_API_SERVER' and use that instead in the other scripts. That's optional for this PR though.
There was a problem hiding this comment.
@thompsonja ok, thanks. I'll fix it
examples/kubernetes/env.sh
Outdated
| @@ -18,7 +23,7 @@ VTCTLD_PORT=${VTCTLD_PORT:-30001} | |||
|
|
|||
| # Get the ExternalIP of any node. | |||
| get_node_ip() { | |||
| $KUBECTL get -o template --template '{{range (index .items 0).status.addresses}}{{if eq .type "ExternalIP" "LegacyHostIP"}}{{.address}}{{end}}{{end}}' nodes --namespace=$VITESS_NAME | |||
| $KUBECTL --server=$KUBERENETAPI get -o template --template '{{range (index .items 0).status.addresses}}{{if eq .type "ExternalIP" "LegacyHostIP"}}{{.address}}{{end}}{{end}}' nodes --namespace=$VITESS_NAME | |||
There was a problem hiding this comment.
@thompsonja I'll remove it, thanks
examples/kubernetes/etcd-down.sh
Outdated
| @@ -13,10 +13,10 @@ cells=`echo $CELLS | tr ',' ' '` | |||
| # Delete replication controllers | |||
| for cell in 'global' $cells; do | |||
| echo "Stopping etcd replicationcontroller for $cell cell..." | |||
| $KUBECTL delete replicationcontroller etcd-$cell --namespace=$VITESS_NAME | |||
| $KUBECTL --server=$KUBERENETAPI delete replicationcontroller etcd-$cell --namespace=$VITESS_NAME | |||
There was a problem hiding this comment.
@thompsonja I'll remove it, thanks
|
re: the CLA check problem. Check the email address which you use in your commits e.g. view it here: https://patch-diff.githubusercontent.com/raw/youtube/vitess/pull/2603.patch I think this email must also be the primary email address of your GitHub account. If there's an inconsistency, you may have to change one of it. |
|
@googlebot I signed it! |
|
I signed it! |
|
@michael-berlin the patch email address is "From: davygeek davygeek@163.com" and GitHub account 's email is "davygeek@163.com Primary Public". Is that right? Thank you |
|
@acharis @michael-berlin the patch email address is "From: davygeek davygeek@163.com" and GitHub account 's email is "davygeek@163.com Primary Public". Is that right? Thank you |
|
I signed it! |
|
@davygeek Can you please try to trigger the googlebot again? It doesn't seem to work when I do it :) re: the review itself. Let's wait for Josh to approve the change. Thanks! :) |
|
I signed it! |
|
@michael-berlin thanks, I trigger the googlebot again, but the cla still "cal:no". I'm very confused. Please help to check the problem, I can't find the cause. Thank you very much. my config base info as follow: // github account info: // cla data |
|
I signed it! |
|
CLAs look good, thanks! |
|
@michael-berlin Thanks very much, The reason is my google develop's account is not match with github account. I used davygeek@163.com as google develop's account the cla is ok. |
|
LGTM, thanks :) |
Add Kuberentes api address config for KUBECTL
The default value is 127.0.0.1:8080
When the Kuberentes api server is not local, We can easily access the api by edit KUBERENETAPI's value