Kubernetes sandbox reliability updates. #2626
Conversation
| return | ||
| logging.fatal('Timed out waiting for initial reparent.') | ||
| return 0 | ||
| logging.error('Timed out waiting for initial reparent.') |
There was a problem hiding this comment.
Add a new line before this line to make it more readable?
| while len(master_tablets) < num_shards: | ||
| if time.time() - start_time > timeout_s: | ||
| logging.error('Timed out waiting to find a replica tablet') | ||
| return 1 | ||
| for shard_name in sharding_utils.get_shard_names(num_shards): |
There was a problem hiding this comment.
Add a newline before this to make it more readable?
helm/vitess/templates/_vttablet.tpl
Outdated
| @@ -176,9 +176,10 @@ volumes: | |||
| {{- $tablet := index . 4 -}} | |||
| {{- with $tablet.vttablet -}} | |||
| {{- $0 := $.Values.vttablet -}} | |||
| {{- $cellClean := $cell.name | replace "_" "-" -}} | |||
There was a problem hiding this comment.
As discussed offline, please fold this into the "format-shard-name" function and rename it to e.g. "clean-label-name".
|
Review status: 0 of 8 files reviewed at latest revision, 3 unresolved discussions. helm/vitess/templates/_vttablet.tpl, line 179 at r2 (raw file): Previously, michael-berlin (Michael Berlin) wrote…
Done. test/cluster/sandbox/initial_reparent.py, line 32 at r2 (raw file): Previously, michael-berlin (Michael Berlin) wrote…
Done. test/cluster/sandbox/initial_reparent.py, line 64 at r2 (raw file): Previously, michael-berlin (Michael Berlin) wrote…
Done. Comments from Reviewable |
|
LGTM |
Main updates: