Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto: Add README.md to document our required style guide. #2663

Merged
merged 1 commit into from
Mar 23, 2017

Conversation

michael-berlin
Copy link
Contributor

No description provided.

Copy link
Contributor

@alainjobart alainjobart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reformat lines to 80 characters

@michael-berlin
Copy link
Contributor Author

Done.

For the record I'm against this practice because the tools cannot reliably do this. For example, I've used the "gq" command in vim and it folded my protobuf examples in the verbatim block into one line :(

@michael-berlin michael-berlin merged commit eaa5cff into vitessio:master Mar 23, 2017
@michael-berlin michael-berlin deleted the protobuf_readme branch March 23, 2017 18:33
frouioui pushed a commit to planetscale/vitess that referenced this pull request Nov 21, 2023
…recated `github.com/golang/mock` with `go.uber.org/mock` (vitessio#2672)

* backport of 2663

* resolve conflict

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

---------

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
frouioui pushed a commit to planetscale/vitess that referenced this pull request Mar 26, 2024
…k` with `go.uber.org/mock` (vitessio#2663)

* cherry pick of 13512

* resolve conflict

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

---------

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants