Json support for RBR. #2800
Merged
Json support for RBR. #2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sougou
approved these changes
Apr 30, 2017
| if toplevel { | ||
| result.WriteString("CAST(") | ||
| } | ||
| fmt.Fprintf(result, "CAST('%04d-%02d-%02d %02d:%02d:%02d", year, month, day, hour, minute, second) |
There was a problem hiding this comment.
This is a DATETIME, not a TIMESTAMP. So it is always UTC.
|
|
||
| // FIXME(alainjobart) this is broken for now. The lack of metadata | ||
| // makes the parsing fail. The MySQL source code is too obscure | ||
| // to make any sense of this. |
There was a problem hiding this comment.
Should we just return an error here?
If we know what json construct could cause this, we can also document it, and may be block it from vttablet.
There was a problem hiding this comment.
+1 on blocking from writing in vttablet, if possible.
This is using the JSON type to echo SQL statements.
This is used by binlog streamer for JSON.
frouioui
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 26, 2024
…ces.SortFunc (vitessio#2800) * cherry pick of 13644 Signed-off-by: Matt Layher <mdlayher@planetscale.com> * go/boost: fix uses of x/exp/slices.SortFunc Signed-off-by: Matt Layher <mdlayher@planetscale.com> --------- Signed-off-by: Matt Layher <mdlayher@planetscale.com> Co-authored-by: Matt Layher <mdlayher@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, only support JSON expressions as SQL, for binlog. UpdateStream support is somewhat different, as values must be printed as JSON strings (like '{"a":25}') instead of the SQL needed to recreate the exact same MySQL internal object (like JSON_OBJECT("a", 25)).