document Ubuntu packages needed for make test
#3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `make test`: The "java" and "local_example" tests failed due to not having `mvn`, so I needed to install the "maven" package. The "vtctld_web" test failed due to "Can't start Xvfb ... No such file or directory" and "WebDriverException: Message: unknown error: cannot find Chrome binary, so I needed to install the "xvfb" and "chromium-browser" packages.
michael-berlin
suggested changes
Aug 15, 2017
There was a problem hiding this comment.
Thank you for the PR :)
Did you run into this problem because you tried to run the tests when you reached the "Run Tests" section?
http://vitess.io/getting-started/local-instance.html#run-tests
If so, we should mention these packages there and not in the beginning of the page. Otherwise, it unnecessarily burdens the reader who just gets started.
Some other note: Please change the Markdown in doc/ and not the generated files in docs/. (This is also documented in docs/README.md.)
changes requested by @michael-berlin
|
@mberlin is this good to merge? |
|
@michael-berlin (pinging the right berlin) |
|
LGTM |
frouioui
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
make test:The "java" and "local_example" tests failed due to not having
mvn, so I needed to install the "maven" package.The "vtctld_web" test failed due to "Can't start Xvfb ... No such file or directory" and "WebDriverException: Message: unknown error: cannot find Chrome binary", so I needed to install the "xvfb" and "chromium-browser" packages.