extend syntax: drop table a, b #3398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sougou
reviewed
Nov 18, 2017
| continue | ||
| } | ||
| tableName := ddl.Table.Name.String() | ||
| tableName := ddl.GetFirstTableName() |
There was a problem hiding this comment.
This needs to be changed to count total rows for all tables.
| } | ||
| } | ||
|
|
||
| func analyzeDDL(ddl *sqlparser.DDL, tables map[string]*schema.Table) *Plan { | ||
| // TODO(sougou): Add support for sequences. | ||
| plan := &Plan{ | ||
| PlanID: PlanDDL, | ||
| Table: tables[ddl.Table.Name.String()], | ||
| Table: tables[ddl.GetFirstTableName()], |
There was a problem hiding this comment.
This part is tough, but the right thing to do is to change Table to Tables here, and iterate on all the tables wherever DDLs are handled. Without this, vttablet will not reload the schema for the rest of the tables.
This change goes deep because the Table info is also used in ACLs, etc. For now, you can change those parts to just use the first entry.
However, doing this will help us eventually fix the issue where we leave this field empty if there are multiple tables in a select.
|
Can you update this to use the new ACL fields I added recently? I think that was the blocker for this PR. |
frouioui
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 26, 2024
…client mount command more standard (vitessio#3402) * backport of 3398 * Fix conflict Signed-off-by: Matt Lord <mattalord@gmail.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sougou
the other way i thought to do this was to break this out of DDL into a DropTable statement type. this seemed a bit quicker. i'm happy to do that, or anything else you might come up with along those lines, or clean up however you like. we obviously don't need this, but it came up and some of our folks sneered a bit.