Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto changes for aggregate stats. #3552

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Conversation

alainjobart
Copy link
Contributor

This would allow re-using the current StreamHealthCheck to convey the
status of a group of tablets, between vtgate and l2vtgate (which will
be merged into vtgate).

This would allow re-using the current StreamHealthCheck to convey the
status of a group of tablets, between vtgate and l2vtgate (which will
be merged into vtgate).
@alainjobart
Copy link
Contributor Author

@sougou This is what we talked about. What do you think? This seems minimal enough, but allows us a ton of flexibility...

(Note the individual fields of AggregateStats may change later, I'm not sure what we'll need).

Later on:

  • TabletStatsCache can export these aggregate (easy to do). It will need to have a per-cell map, so its tablet status map may gain an extra map[string] layer with the cell.
  • when l2vtgate exposes its queryservice, it can send these aggregate up (easy as well).
  • both discoverygateway and l2vtgategateway can then expose these aggregates (easy as well).
  • the srvtopo module can then use them to find the right targets in the right cells, according to a provided policy.
  • vtgate can expose a queryservice interface, that connects its internal aggregates and discoverygateway to the outside. We can then retire l2vtgate.
  • we can then implement a hybrid gateway, that would allow vtgate to have both local tablets, and remote vtgates.

None of these steps are hard, I'll work on them one at a time.

@demmer does that make sense to you too?

@sougou
Copy link
Contributor

sougou commented Jan 12, 2018

LGTM

Approved with PullApprove

@sougou sougou merged commit 3f0b610 into vitessio:master Jan 12, 2018
@sougou
Copy link
Contributor

sougou commented Jan 12, 2018

lol. too late. missed the follow up questions.
But I agree with the changes (given that we discussed them).

Copy link
Member

@demmer demmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes and overall approach sounds good to me too.

frouioui pushed a commit to planetscale/vitess that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants