vtgate: fix vtgate_test #3561
Merged
vtgate: fix vtgate_test #3561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parsing of flags in vtgate_test caused it to eat all flags including the ones used by the test package. This caused tests here to ignore things like -run, etc. I tried changing the init to TestMain. That didn't help. So, I'm removing the parsing call for now until we figure out a different way to fix this.
demmer
approved these changes
Jan 17, 2018
alainjobart
approved these changes
Jan 17, 2018
frouioui
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 26, 2024
…t selection: pick non-serving tablets in Reshard workflows (vitessio#3603) * backport of 3561 * Adjust for v18 Signed-off-by: Matt Lord <mattalord@gmail.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com>
systay
pushed a commit
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parsing of flags in vtgate_test caused it to eat all flags
including the ones used by the test package. This caused tests
here to ignore things like -run, etc.
I tried changing the init to TestMain. That didn't help. So,
I'm removing the parsing call for now until we figure out a
different way to fix this.