add positional argument validation #3573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add servenv.ParseFlags and servenv.ParseFlagsAndArgs to handle the common logic around parsing flags, handling the -version flag to print version, and verify that positional arguments either are or are not supplied as expected.
demmer
force-pushed
the
handle-positional-arguments
branch
from
cc68b87
to
489c422
Compare
|
LGTM |
frouioui
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add servenv.ParseFlags and servenv.ParseFlagsAndArgs to handle the
common logic around parsing flags, handling the -version flag to
print version, and verify that positional arguments either are or
are not supplied as expected.
This addresses a current issue in which vtgate (and possibly other) commands
silently ignore any positional arguments.