vttablet: get_lock and release_lock #3663
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #3631 get_lock and release_lock cannot be passed through to MySQL because their behavior is connection dependent, which doesn't work well for distributed systems, and for pooled connections. So, we implement our own version of these functions that are more distributed system friendly, with timeouts as well as session independent behaviors. More details on the issue.
|
I accidentally created a youtube/vitess branch for this. I'll reopen this PR from a personal branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3631
get_lock and release_lock cannot be passed through to MySQL because
their behavior is connection dependent, which doesn't work well
for distributed systems, and for pooled connections.
So, we implement our own version of these functions that are more
distributed system friendly, with timeouts as well as session
independent behaviors. More details on the issue.