Kill vtctld commands that outlive the http request context #4189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Weitzman <dweitzman@pinterest.com>
dweitzman
force-pushed
the
vtctld_timeout
branch
from
d83fc7f
to
ee10451
Compare
sougou
approved these changes
Sep 8, 2018
|
I decided to merge this because other people have also run into this, and deleting the lock file in topo has generally been a bigger pain. |
systay
pushed a commit
that referenced
this pull request
Jul 22, 2024
Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution: I haven't tested this yet.
I've encountered situations where a vtctld command hangs and leaves a lock file sitting around in the topology.
The default timeout for vtctl is 24 hours, so in these situations you have to manually go into the topology and delete lock files.