Allow setting callerid in vtworker #4243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafael
reviewed
Oct 4, 2018
go/cmd/vtworker/vtworker.go
Outdated
| @@ -41,6 +42,7 @@ import ( | |||
| var ( | |||
| cell = flag.String("cell", "", "cell to pick servers from") | |||
| commandDisplayInterval = flag.Duration("command_display_interval", time.Second, "Interval between each status update when vtworker is executing a single command from the command line") | |||
| immediateCaller = flag.String("callerid", "", "immediate CallerID to set when querying vttablet") | |||
There was a problem hiding this comment.
nit - I would call this flag the same way as vtctl, so it is consistent:
username := subFlags.String("username", "", "If set, value is set as immediate caller id in the request and used by vttablet for TableACL check")
if *username != "" {
ctx = callerid.NewContext(ctx,
callerid.NewEffectiveCallerID("vtctl", "" /* component */, "" /* subComponent */),
callerid.NewImmediateCallerID(*username))
}
There was a problem hiding this comment.
Renamed the flag to "username" and copied the flag description from vtctl
dweitzman
force-pushed
the
vtworker_callerid_param
branch
2 times, most recently
from
52ce53b to
b595bb4
Compare
The -username flag serves the same purpose as the corresponding flag on vtctl: to avoid getting blocked by strict table acl checks. Signed-off-by: David Weitzman <dweitzman@pinterest.com>
dweitzman
force-pushed
the
vtworker_callerid_param
branch
from
b595bb4 to
8872101
Compare
sougou
approved these changes
Oct 4, 2018
|
This diff does not help in vtworker interactive or web mode and does not support setting groups along with the callerid. I have some code for that, but it feels messy so I'm not planning to mail it out unless other folks run into this problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid getting stuck on any strict table acl checks when resharding
Signed-off-by: David Weitzman dweitzman@pinterest.com