-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: logging improvements #4343
Conversation
group=2000 + user=1000 to match existing helm vttablet deployments Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There are two things still bothering me about logging.
|
Signed-off-by: Derek Perkins <derek@derekperkins.com>
the previous method didn’t listen for SIGTERM and so would block restarting Signed-off-by: Derek Perkins <derek@derekperkins.com>
this doesn’t require root privileges to run, and also listens for SIGTERM Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
also rename slow.log to slow-query.log to match Vitess defaults Signed-off-by: Derek Perkins <derek@derekperkins.com>
97ca0be
to
c15a90f
Compare
Signed-off-by: Derek Perkins <derek@derekperkins.com>
080d0e5
to
c9e5b22
Compare
Ok, I solved those two problems.
This has been bugging me for a year and I feel pretty good about these changes. @dkhenry - if you could take another look, I made a lot of changes after your last LGTM. |
This is a great quality of life improvement 👍 |
This PR adds log rotation via logrotate to the helm chart. By default, it rotates logs at 100M, running on an hourly cron.
This also uses the same
debian:stretch-slim
to tail the error and slow logs, and adds a vitess user/group.@sougou - Can you create a new Docker repo for
logrotate
andlogtail
and have them auto-build like the others?