Add support for substr for static strings. #4350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sougou
reviewed
Nov 9, 2018
| @@ -3000,18 +3000,25 @@ func (node *ValuesFuncExpr) replace(from, to Expr) bool { | |||
| // SubstrExpr represents a call to SubstrExpr(column, value_expression) or SubstrExpr(column, value_expression,value_expression) | |||
There was a problem hiding this comment.
I thought about it, but if I reuse ColName , e.g.:
SUBSTR openb STRING ',' value_expression closeb
{
$$ = &SubstrExpr{Name: &ColName{Name: NewColIdent($3)}, From: $5, To: nil}
}
How could I figure out later if it's a static string or column name? How could I stop walkSubtree in this case?
Maybe instead of having extra StrVal *SQLVal, I'll add some boolean member (static/resolved/...) to mark it's a static string expression.
There was a problem hiding this comment.
Oh. You misunderstood :). I just wanted the SubstrExpr comment to be updated to say that the input can be a column or a value, to reflect the code change.
There was a problem hiding this comment.
Ok, how about now - take a look.
Signed-off-by: kuba-- <kuba@sourced.tech>
sougou
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuba-- kuba@sourced.tech
So far vitess supports
substringforcolumns_names. This PR adds support for static string values, so you can: