Do not reuse a consul lock #4353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When you lose a consul lock, you can't reuse that lock. Existent code does not does that and should a vtctld master lose a lock, it gets stuck in a state where it can't never use that lock again and you will need to restart the process. Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
|
This is not ready for review yet. Still need to understand some more details about consul client API. |
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
demmer
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
does that and if a vtctld master loses a lock, it gets stuck in a state
where it can't never recover and you'll need to restart the process.
Signed-off-by: Rafael Chacon rafael@slack-corp.com