specify the character set in buildVarCharFields #4364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some mysql clients get confused if fields queries don't return a character set, so extend buildVarCharFields to specify utf8 and non-null flags for all internally generated varchar fields. This is only used by `show` statements currently. Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
sougou
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some mysql clients get confused if fields queries don't return a
character set, so extend buildVarCharFields to specify utf8 and
non-null flags for all internally generated varchar fields.
This is only used by
showstatements currently.