Upgrade grpc-go to 1.15 #4376
Merged
Upgrade grpc-go to 1.15 #4376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leo Xuzhang Lin <llin@hubspot.com>
|
The latest release looks to be 1.16: Is there some reason we wouldn't want to upgrade to that? |
|
We were a bit hesitant to upgrade to that internally since that release is less than a month old. |
sougou
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grpc-java we use in the client is upgraded to 1.15.0 in #4218
This upgrades the grpc-go server version to match the client version.
We've seen improvements to graceful closures on the upgrade as there had been numerous transport level bug fixes since 1.11.
cc @acharis
Signed-off-by: Leo Xuzhang Lin llin@hubspot.com