helm: multiple schema and vschema jobs #4388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since jobs are one-time non-updateable processes, we need a way to allow evolution. This change allows you to name the schema and vschema specs, thereby allowing you to add new schema changes, and expire completed jobs. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
derekperkins
approved these changes
Nov 25, 2018
There was a problem hiding this comment.
I think this is a good change. I'm trying to think how I want to use it. By never deleting any jobs, you have a record in k8s of exactly when they were applied which is nice. That'd also require a workflow that called for a helm upgrade for every application.
Anyhow, I like this and as people start using it, we can think about continuing to flesh out the process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since jobs are one-time non-updateable processes, we need
a way to allow evolution. This change allows you to name
the schema and vschema specs, thereby allowing you to
add new schema changes, and expire completed jobs.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com