Topo to topo compare #4392
Merged
Topo to topo compare #4392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
demmer
requested changes
Nov 26, 2018
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
rafael
force-pushed
the
topo-to-topo-compare
branch
from
884003c
to
e67e7d3
Compare
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
|
@demmer - comments have been addressed. Good catch of parallelisms. I refactored copy to also reflect this. |
demmer
previously requested changes
Nov 27, 2018
sougou
reviewed
Dec 16, 2018
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
sougou
approved these changes
Dec 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following extends
topo2topotool to add a compare option flag. When this flag is passed, the tool will comparefromandtotopologies and error if they are not in sync.This is useful to make sanity checks before doing cutovers when migrating from different topologies.
The approach I took to make this compare is to follow the same steps as copy and perform a
DeepEqualbetween the data structures coming fromfromTSandtoTS.