replace the logstats RemoteAddr with a more inclusive CallInfo #4422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the gRPC method was not included in the tablet query logs which made debugging an ExecuteBatch vs Execute issue challenging. To address this, replace the existing RemoteAddr hook with the more generic CallInfo.Text() result that includes both the remote addr and the method in the case of gRPC. Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
|
This LGTM. 👍 |
sougou
approved these changes
Dec 16, 2018
frouioui
added a commit
to planetscale/vitess
that referenced
this pull request
Mar 26, 2024
… rule query rewrite (vitessio#4422) * backport of 4419 * fix DML routed queries Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the gRPC method was not included in the tablet query logs
which made debugging an ExecuteBatch vs Execute issue challenging.
To address this, replace the existing RemoteAddr hook with the more
generic CallInfo.Text() result that includes both the remote addr and the
method in the case of gRPC.