[vt/discovery] Add region context in GetAggregateStats - v2 #4476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafael
changed the title
sougou
approved these changes
Dec 21, 2018
| @@ -27,9 +27,6 @@ import ( | |||
| // routing of queries. | |||
| // - discovery.TabletStatsCache will implement the discovery part of the | |||
| // interface, and discoverygateway will have the QueryService. | |||
| // - hybridgateway will also implement this interface: for each l2vtgate pool, | |||
| // it will establish a StreamHealth connection, and store the returned | |||
| // health stats. | |||
| type TargetStats interface { | |||
There was a problem hiding this comment.
I believe this is also essentially obsolete. Let's look at getting rid of this at the next iteration.
Essentially, we should get rid of AggregateStats. We should only have a map[cell]*TabletStatsCache that vtgate directly pulls and populates from the tablets it's connected to.
There was a problem hiding this comment.
That makes sense. Sounds good.
|
Oh. There are conflicts resolve. |
rafael
force-pushed
the
add-region-context-aggr-stats-remove-l2vtgates
branch
from
2110a4c
to
d51a7b9
Compare
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
* This change allows to have constant time resolution of aggregates per region Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
…ct def Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
rafael
force-pushed
the
add-region-context-aggr-stats-remove-l2vtgates
branch
from
d51a7b9
to
0217138
Compare
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
sougou
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GetAggregateStats#4459.