helm: handle Orchestrator during preStop shutdown hook #4493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Perkins <derek@derekperkins.com>
derekperkins
force-pushed
the
orc-reparent-api
branch
2 times, most recently
from
b613313
to
308f3ec
Compare
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
derekperkins
force-pushed
the
orc-reparent-api
branch
from
308f3ec
to
87c0f0c
Compare
|
Sorry for not jumping in on the Slack discussion. I think the |
|
The refresh before forgetting comes from Hubspot's production setup. I'm not sure what the reasoning behind it was. Do you think beginning and ending downtime around the planned reparent is a good idea? |
Definitely. |
|
Great. This is ready to be merged. Since this contains a change to the Dockerfile, once this PR is merged, I'll wait for the auto-build to apply the change, then tag a new helm release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per my conversation with @acharis on Slack, https://vitess.slack.com/archives/C0PQY0PTK/p1545344028308100, I've added some api calls to the k8s preStop shutdown hook.
The ordering that we discussed was:
In addition to adding those calls, I also manually downtimed Orchestrator for
3010 seconds, though I'm curious to hear feedback on that. The final setup looks like:edit: changed Orchestrator downtime from 30 seconds to 10 seconds after discussing with @acharis on Slack
cc @hmcgonig @shlomi-noach