Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm/orchestrator: set FailMasterPromotionIfSQLThreadNotUpToDate = true #4506

Merged
merged 1 commit into from
Jan 8, 2019
Merged

helm/orchestrator: set FailMasterPromotionIfSQLThreadNotUpToDate = true #4506

merged 1 commit into from
Jan 8, 2019

Conversation

derekperkins
Copy link
Member

implementing recommendation from @shlomi-noach

use FailMasterPromotionIfSQLThreadNotUpToDate: true to avoid promoting a replica which is not up-to-date. Work in progress to actually force orchestrator to wait for it to become up-to-date.

https://vitess.slack.com/archives/CB1H5S0JZ/p1546976863004700

@derekperkins
helm: FailMasterPromotionIfSQLThreadNotUpToDate=tr
85253b8 
Signed-off-by: Derek Perkins <derek@derekperkins.com>
dkhenry
dkhenry approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@dkhenry dkhenry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dkhenry dkhenry merged commit 636b5a1 into vitessio:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhenry dkhenry dkhenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derekperkins @dkhenry