Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check perceived tablet type before taking a backup #4508

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Check perceived tablet type before taking a backup #4508

merged 1 commit into from
Jan 9, 2019

Conversation

rafael
Copy link
Member

@rafael rafael commented Jan 8, 2019

Description

  • Fixes issue where it is possible to backup a tablet that reparented and didn't get the memo that it changed it's state due to a network partition.

Tests

  • Pretty small change, tested in our environment that this works as expected. I don't see relevant unit tests around this rpc call. I can iterate in adding those as a different PR.

@rafael
Check perceived tablet type before taking a backup
876b842 
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael rafael requested a review from sougou as a code owner January 8, 2019 23:29
@sougou sougou merged commit 5cafa54 into vitessio:master Jan 9, 2019
systay pushed a commit that referenced this pull request Jul 22, 2024
@joemiller @dbussink
gcsbackup: use Application Default Credentials for GCP API auth (#4508)
c4a006b 
* gcsbackup: deprecate --psdb.gcs_backups.creds_path flag

* Mark the option as deprecated

This deals with throwing a warning when given and removes it from the help output.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

---------

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafael @sougou